-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added LM Studio Support to Fabric #952
base: goVersion
Are you sure you want to change the base?
Conversation
…use the key is external)
@sosacrazy126 You the man! Thank you! |
Did this merge work as it doesn't seem like the update went through or I am missing something ? |
Here's an improved version of the message: @sosacrazy126, thank you for your PR! I have a few points for you to consider:
ret.VendorsAll.AddVendors(
openai.NewClient(),
azure.NewClient(),
ollama.NewClient(),
groc.NewClient(),
gemini.NewClient(),
anthropic.NewClient(),
lm.NewClient() // Add your new vendor here
) With this approach, we don’t require additional flags like
func NewClient() (ret *Client) {
ret = &Client{}
ret.Client = openai.NewClientCompatible("Groc", "https://api.groq.com/openai/v1", nil)
return ret
}
type Client struct {
*openai.Client
} Let me know if this makes sense or if you have further questions! |
Add SiliconCloud support
Add Openrouter Vendor support
…cause of ENV prefix for setting.
…cause of ENV prefix for setting.
@eugeis, thank you! I’ll go ahead and implement your suggestion. One question from your overview: Did my implementation seem overly complicated? |
im finalizing the merge and testing. |
…ad of the system role for the pattern. It is needed for Open AI o1 models for now.
…c.) and use the user role instead of the system role.
…c.) and use the user role instead of the system role.
add mistral vendor
Hi, I tried reviewing your updated code, but it's difficult because 90 files have been updated, and it's not clear why. Could you please submit a new pull request that includes only the new feature (LM Studio support)? Thanks! |
This pull request adds support for LM Studio to Fabric. It includes:
Please review the changes and let me know if any adjustments are needed.